Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTM-836]Rework Init workflow #4377

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[GTM-836]Rework Init workflow #4377

wants to merge 9 commits into from

Conversation

ElijahAhianyo
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@ElijahAhianyo ElijahAhianyo changed the title [WIP]Rework Init workflow [GTM-836]Rework Init workflow Nov 13, 2024
Copy link

linear bot commented Nov 13, 2024

@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review November 13, 2024 17:59
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flow is working pretty well for me.

I'm wondering if we shouldn't show the urls for flexgen / templates and instead if they press (1) we do the ai workflow (this is already done). and if they press (2) then we open the templates page for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants